Merge pull request #2 from shellrent/php80

Migration to PHP 8.0
shellrent · Jan 4, 2024 · fb8e543 · fb8e543
2 parents 56f412a + 1d0ad0d
commit fb8e543
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/LEFunctions.php b/src/LEFunctions.php
@@ -83,8 +83,6 @@ public static function RSAGenerateKeys($directory, $privateKeyFile = 'private.pe
 
 		file_put_contents($privateKeyFile, $privateKey);
 		file_put_contents($publicKeyFile, $details['key']);
-
-		openssl_pkey_free($res);
 	}
 
     /**
@@ -128,8 +126,6 @@ public static function ECGenerateKeys($directory, $privateKeyFile = 'private.pem
 
 		file_put_contents($privateKeyFile, $privateKey);
 		file_put_contents($publicKeyFile, $details['key']);
-
-		openssl_pkey_free($res);
 	}
 
 

diff --git a/src/LEOrder.php b/src/LEOrder.php
@@ -74,7 +74,7 @@ class LEOrder
      * @param string 		$notBefore 			A date string formatted like 0000-00-00T00:00:00Z (yyyy-mm-dd hh:mm:ss) at which the certificate becomes valid.
      * @param string 		$notAfter 			A date string formatted like 0000-00-00T00:00:00Z (yyyy-mm-dd hh:mm:ss) until which the certificate is valid.
      */
-	public function __construct($connector, $log, $certificateKeys, $basename, $domains, $keyType = 'rsa-4096', $notBefore, $notAfter)
+	public function __construct($connector, $log, $certificateKeys, $basename, $domains, $keyType, $notBefore, $notAfter)
 	{
 		$this->connector = $connector;
 		$this->basename = $basename;