Better compatibility with MSVC compiler #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some Microsoft Visual Studio 14.0 specific failure with this change. |
|
I will try to fix the issue, which is most likely related to constexpr not being fully implemented in Microsoft's C++14 in the Visual Studio 14. |
|
I think the macos runners must be dead now (I'll do a followup PR), thanks for the change and sorry for being slow to respond! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the need to include
/Zc:__cplusplusin Visual Studio projects, by replacing__cplusplusmacro withutf8_cplusplus, which uses_MSVC_LANGto get the current C++ version. On other compilersutf8_cplusplusis defined as__cplusplus.