Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail generation #17

Merged
merged 20 commits into from
May 23, 2019
Merged

Thumbnail generation #17

merged 20 commits into from
May 23, 2019

Commits on May 21, 2019

  1. Implemented Qt::KeepAspectRatioByExpanding

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    07c31b9 View commit details
    Browse the repository at this point in the history

  2. New N3_FULL values

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    769d4ec View commit details
    Browse the repository at this point in the history

  3. Fixed bug in image dir creation

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    981c195 View commit details
    Browse the repository at this point in the history

  4. Updated H2O N3_FULL value based on @NiLuJe's comment

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    304dda7 View commit details
    Browse the repository at this point in the history

  5. Reworked koboCover and resizing 

    * Reduces memory usage by using a base64.Decoder instead of storing the temp
  image in memory.
* Simplified resize logic.
* Reorganize koboCover stuff.
* Extract image dir hashing to util.
* Use filepath instead of path.
    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    b928ecb View commit details
    Browse the repository at this point in the history

  6. Simplified image resizing 

    * Loop over cover types instead of duplicating code
* Fix: Create the parent dir for images
* Show errors from imaging.Encode
* Close files sooner
    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    bc22dde View commit details
    Browse the repository at this point in the history

  7. Added unit tests for hashedImageParts 

    * Also fixed bug in hashedImageParts about forgetting to return dir1 and dir2
    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    3d3b5c5 View commit details
    Browse the repository at this point in the history

  8. Added tests for koboCover.RelPath 

    * Also fixed file extension
    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    34f732d View commit details
    Browse the repository at this point in the history

  9. Added tests for koboCover.String and koboCover.Size

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    96a55e3 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/master' into thumbnails

    @pgaskin
    pgaskin committed May 21, 2019
    Configuration menu
    Copy the full SHA
    bf088e5 View commit details
    Browse the repository at this point in the history

  11. Request full cover size from Calibre

    @shermp
    shermp committed May 21, 2019
    Configuration menu
    Copy the full SHA
    575ada6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Fixed image dir path

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    e4c744d View commit details
    Browse the repository at this point in the history

  2. Also generate N3_FULL

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    b2ad269 View commit details
    Browse the repository at this point in the history

  3. Implement and use KeepAspectRatio for fullCover

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    f0f3d9c View commit details
    Browse the repository at this point in the history

  4. Fix rounding in resize

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    dd0aeff View commit details
    Browse the repository at this point in the history

  5. More tests

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    4646add View commit details
    Browse the repository at this point in the history

  6. Improvements as per @NiLuJe's comments 

    * Better logging for image resizr
* More readable resize formula
    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    b5fa6ff View commit details
    Browse the repository at this point in the history

  7. Don't resize image if already correct size

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    504d4f6 View commit details
    Browse the repository at this point in the history

  8. Printf -> Println

    @pgaskin
    pgaskin committed May 22, 2019
    Configuration menu
    Copy the full SHA
    9b7f9a4 View commit details
    Browse the repository at this point in the history

  9. Move wg.Wait() to correct location

    @shermp
    shermp committed May 22, 2019
    Configuration menu
    Copy the full SHA
    7723c73 View commit details
    Browse the repository at this point in the history