-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Profile for Ruby #8
base: master
Are you sure you want to change the base?
Conversation
@hmistry Thank you for the PR, though there are a lot of different changes here. Firstly, I think we shouldn't create separate Ruby files for each memory profiling method, I think that profilers should be activated via environment variables. So when we run Secondly, I think there is no point using Thirdly, I think bringing Is there some generic tool for monitoring memory usage? I mean, I think the Ruby implementation of monitoring RSS is great, I was just wondering if we could leverage some existing tool so that it's more language-agnostic. |
@janko-m All valid points... here some context. I needed to compare for my use case between node vips, ruby vips, and ruby minimagick to better understand the performance and this project was a good starting point. I'm sharing the results back incase others are interested. (I'm ok if you choose to not to merge/close it. 😃) If there's any PR to merge, it is #6 because the node implementation is not preserving the aspect ratio. Commenting to your points:
|
Added some memory profile usage for Ruby ones - the results are in prof_results.txt. I'm not sure if this is the right way or not especially with external libraries involved - open to feedback for doing it the right way.