Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version, implement relevant features and bug fixes #39

Merged
merged 23 commits into from
Oct 7, 2022
Merged

Conversation

po09i
Copy link
Member

@po09i po09i commented Apr 12, 2022

Description

This PR bumps the version of Shimming toolbox to version: 7087b9f20ef2bb0f1366dd8e6a8dfc440b349aed

It also adds the following features relevant to the new version:

  • There is a new 'auto' value for the --slice option. Sets it as the default option.
  • If the --slice option is set to auto, the --slice-factor option is not displayed.
  • fatsat dropdown
  • Add the regularization factor option
  • Refactors how the help text gets fetched to be automated

If fixes the following bugs:

  • Floating window caused an error when selecting a button that imported from the overlay
  • When required arguments were not filled in, the error message was displayed on the terminal instead of fsleyes
  • The scrolled window was not being updated when changing dropdown tabs
  • Paths with spaces are now correctly handled (dcm2bids does not handle them, so that is still an issue)

Linked Issues

Fixes #44
Fixes #38
Fixes #43
Fixes #42

@po09i po09i changed the title Bump version and implement relevant features Bump version, implement relevant features and bug fixes May 3, 2022
Copy link
Member

@4rnaudB 4rnaudB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues #38, #43 and #42 were fixed, but there is still an error for #44 when adding a space in file path and subject name on Linux mint. In the Dicoms to Niftis window, I was successful with a folder path without spaces, but the program failed when I added one. Same thing happened with the subject name option.

@po09i
Copy link
Member Author

po09i commented Oct 6, 2022

@4rnaudB Can you try the other CLIs? Everything should work except st_dicom_to_nifti (dcm2bids does not support it yet). I updated the description to mention that st_dicom_to_nifti does not work since it's a dcm2bids issue.

@po09i po09i requested a review from 4rnaudB October 7, 2022 14:25
Copy link
Member

@4rnaudB 4rnaudB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@po09i po09i merged commit bc5ab5e into main Oct 7, 2022
@po09i po09i deleted the ad/bump-version branch October 7, 2022 14:37
@po09i po09i added this to the 1.0 milestone Aug 15, 2024
@po09i po09i added Package: Plugin enhancement New feature or request labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Package: Plugin
Projects
None yet
2 participants