Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc/cleanup #40

Merged
merged 24 commits into from
Apr 21, 2022
Merged

Gc/cleanup #40

merged 24 commits into from
Apr 21, 2022

Conversation

gaspardcereza
Copy link
Member

@gaspardcereza gaspardcereza commented Apr 12, 2022 •
edited
Loading

Description

General cleanup/improvement of the plugin:

  • Remove useless functions/classes
  • Move ST window to top
  • Move terminal in separate window and use the same with all tabs
  • Resize scroll window virtual size with content when elements are added
  • Add logos/icons for aesthetic purpose

Other potential ideas:

  • In Change run button #4, Ainsleigh suggested to place the run button on top so that it's always visible. This makes sense but I did'nt know where to put it.
  • I could be good to move the info sizer (on the left) out of the scrolling window but I haven't figured that out yet.
    -Separate the code into different files to make it easier to navigate and avoid a file with 2000+ lines.

Linked Issues

Closes #3
Closes #7

@gaspardcereza gaspardcereza requested a review from po09i April 12, 2022 12:55
po09i
po09i reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@po09i po09i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add a brief doctoring description for undocumented classes.

I took a brief look at the PR

fsleyes_plugin_shimming_toolbox/st_plugin.py Outdated Show resolved Hide resolved
fsleyes_plugin_shimming_toolbox/st_plugin.py Show resolved Hide resolved
fsleyes_plugin_shimming_toolbox/st_plugin.py Outdated Show resolved Hide resolved
fsleyes_plugin_shimming_toolbox/st_plugin.py Outdated Show resolved Hide resolved
installer/install_shimming_toolbox.sh Outdated Show resolved Hide resolved
@po09i
Copy link
Member

po09i commented Apr 12, 2022

The button looks a bit weird: Screen Shot 2022-04-12 at 11 21 44 AM

@gaspardcereza @po09i
Remove blank space
4fe2e5e 
Co-authored-by: Alex Dastous <[email protected]>
@gaspardcereza
Copy link
Member Author

The button looks a bit weird: Screen Shot 2022-04-12 at 11 21 44 AM

That's weird it looks ok on my end:
image

@po09i
Copy link
Member

po09i commented Apr 20, 2022

@gaspardcereza I reviewed it a second time, let me know what you think of the changes!

@gaspardcereza gaspardcereza merged commit 4c4a0cb into main Apr 21, 2022
@gaspardcereza gaspardcereza deleted the gc/cleanup branch April 21, 2022 16:00
This was referenced Apr 21, 2022
Closed
Closed
@po09i po09i added this to the 1.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@po09i po09i po09i approved these changes

Assignees
No one assigned
Labels
Package: Plugin refactoring Code refactoring
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Terminal doesn't show by default Expand terminal size to fit window
2 participants
@gaspardcereza @po09i