Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix #67

Merged
merged 2 commits into from
Mar 6, 2024
Merged

bug fix #67

merged 2 commits into from
Mar 6, 2024

Conversation

4rnaudB
Copy link
Member

@4rnaudB 4rnaudB commented Mar 4, 2024

Checklist

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've added relevant tests for my contribution
  • I've updated the documentation and/or added correct docstrings
  • I've assigned a reviewer

Description

There was a bug where if no order was selected in the GUI, the ran command would send an empty string as coil orders. Changed it to -1.

@4rnaudB 4rnaudB requested a review from po09i March 4, 2024 22:21
@4rnaudB 4rnaudB merged commit a832250 into main Mar 6, 2024
3 checks passed
@4rnaudB 4rnaudB deleted the ab/correction branch March 6, 2024 14:40
@po09i po09i added this to the 1.0 milestone Aug 15, 2024
@po09i po09i added Package: Plugin bug Something isn't working labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@po09i po09i po09i approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Package: Plugin
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@4rnaudB @po09i