Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile aptos-node package separately #16

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Compile aptos-node package separately #16

merged 2 commits into from
Oct 2, 2024

Conversation

jasonxh
Copy link
Contributor

@jasonxh jasonxh commented Oct 2, 2024

#13 incorrectly changed how aptos-node is compiled, causing the following error

thread 'main' panicked at aptos-move/aptos-vm/src/natives.rs:189:5:
aptos-node was compiled with feature flags that shouldn't be enabled.
This is caused by cargo's feature unification.
When you compile two crates with a shared dependency, if one enables a feature flag for the dependency, then it is also enabled for the other crate.
PLEASE RECOMPILE APTOS-NODE SEPARATELY using the following command:
    cargo build --package aptos-node
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@jasonxh jasonxh requested a review from jachen-sh October 2, 2024 04:06
@@ -24,7 +27,7 @@ RUN git init && \
git fetch --depth 1 origin ${APTOS_GIT_REVISION} && \
git checkout FETCH_HEAD

RUN cargo build --locked --release --bin aptos-node
RUN cargo build --locked --release --package aptos-node
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. The rest are further cache tunings.

@jasonxh jasonxh merged commit 91db064 into main Oct 2, 2024
3 checks passed
@jasonxh jasonxh deleted the hao/fix-node branch October 2, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant