Build aptos-node-v1.23.3 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpeng-sh
reviewed
Nov 21, 2024
| runs-on: ubuntu-latest | ||
| outputs: | ||
| aptos_git_sha: ${{ steps.resolve.outputs.aptos_git_sha }} | ||
| steps: |
There was a problem hiding this comment.
Instead of cloning/downloading the repo, would it make more sense to just use the github REST API?
https://api.github.com/repos/aptos-labs/aptos-core/git/refs/tags/aptos-node-v1.23.3 seems to return everything we need.
There was a problem hiding this comment.
That's a good idea, but it'll be a little trickier to be able to support other ref kinds (branches, commits).
jachen-sh
reviewed
Nov 21, 2024
jachen-sh
approved these changes
Nov 21, 2024
jasonxh
added a commit
to shinamicorp/sui-docker
that referenced
this pull request
Nov 27, 2024
Porting over same changes from shinamicorp/aptos-docker#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also decouple the target ref from the actual commit. Always (re)resolve the target ref into the commit SHA before building, and cache the binaries image based on SHA instead. This improves both of these scenarios:
[sc-4521]