Accept empty assertion of attribute query response

shingo78 · Jan 9, 2020 · 653466e · 653466e
1 parent e869cae
commit 653466e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/Auth/Process/attributeaggregator.php b/lib/Auth/Process/attributeaggregator.php
@@ -239,11 +239,13 @@ public function process(&$state)
                     $response->getStatus()['Code'].')');
             }
             // merge attributes
-            $assertion = $response->getAssertions()[0]; // TODO Can there be more than 1?
-            if (empty($assertion)) {
-                throw new RuntimeException('Got an empty SAML Response');
+            $assertions = $response->getAssertions();
+            if (!empty($assertions)) {
+                $attributes_from_aa = $assertions[0]->getAttributes();
+            } else {
+                $attributes_from_aa = array();
             }
-            $this->mergeAttributes($state, $assertion->getAttributes());
+            $this->mergeAttributes($state, $attributes_from_aa);
 
         } catch (Exception $e) {
             \SimpleSAML\Logger::info("Attribute query failed: ".$e->getMessage());