Removes extraneous "\n" at the end of packets #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes warnings like this /var/log/carbon/listener.log : 17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring 17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring 17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring 17/07/2016 03:44:30 :: invalid line () received from client 127.0.0.1:47869, ignoring Empty string between parenthesis suggests that an empty line is sent to graphite. Indeed, inspection of lo interface with tcpdump/wireshark shows packets ending with "0a0a". The suggested fix is not very elegant but it does the job, at least on my system (centos 7.2, shinken 2.4.3 and graphite-web 0.9.15 from EPEL repo, and mod-graphite as downloaded from shinken.io, which I found to be identical to the current module in "refactored" branch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings like this /var/log/carbon/listener.log :
17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring
17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring
17/07/2016 03:44:29 :: invalid line () received from client 127.0.0.1:47869, ignoring
17/07/2016 03:44:30 :: invalid line () received from client 127.0.0.1:47869, ignoring
Empty string between parenthesis suggests that an empty line is sent to
graphite.
Indeed, inspection of lo interface with tcpdump/wireshark shows packets ending with "0a0a".
The suggested fix is not very elegant but it does the job, at least on my
system (centos 7.2, shinken 2.4.3 and graphite-web 0.9.15 from EPEL
repo, and mod-graphite as downloaded from shinken.io, which I found to
be identical to the current module in "refactored" branch).