Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about #715 #716

Open
wants to merge 3 commits into
base: integ
Choose a base branch
from
Open

about #715 #716

wants to merge 3 commits into from

Conversation

rednach
Copy link

@rednach rednach commented Apr 26, 2019

Defining ui-graphite with enabled=0 and this patch make graphs to appear.

Related with shinken-monitoring/mod-ui-graphite#24

@mohierf
Copy link
Contributor

mohierf commented Apr 27, 2019

Thanks @rednach for this PR. I will integrate this in my most recent work and keep you informed.

@rednach
Copy link
Author

rednach commented Apr 27, 2019

Thanks to you, @mohierf.

In order to get shinken-ui injecting external commands into alignak, I am working in:

  • to discard default "alignak_endpoint" (alignak arbiter) as target, because arbiter does not push them to scheduler.
  • to use receiver+web-services... but not changing "alignak_endpoint" (it use it to get alignak status and event logs) , but adding a new module parameter (i.e. alignak_ws=http://127.0.0.1:7773/ws).
  • to reuse ExternalCommandManager from alignak to decode command string and AlignakConnection from alignak_webui to login(!!) and post the result...

what do you think? better for me just to wait for your next commits?

@mohierf
Copy link
Contributor

mohierf commented Apr 27, 2019

@rednach : have a look to the python3 branch in my own repo here: https://github.com/mohierf/mod-webui

I already modified external commands behavior and it looks ok. Moreover this version is compatible with Python 3 !

@mohierf
Copy link
Contributor

mohierf commented Apr 29, 2019

@rednach I did some more testings and the module ui-graphite2 is not easily inclmuded by the current WebUI. My most recent push in the python3 branch is not yet fully functional but I will make more tests in the next few days!

@rednach
Copy link
Author

rednach commented May 3, 2019

@mohierf Now, your python3 branch is working with alignak/develop (or alignak/module_on_module), but yet with the disable/enable trick to load ui-graphite2 (and another patch about "quote", I suppose because I use python 2).

@mohierf
Copy link
Contributor

mohierf commented May 5, 2019

@rednach: I am still fixing this behaviour. I identified precisely what is the problem but do not have much time at the moment ... I will release an Alignak and WebUI version that ill make the job soon 😉

@mohierf
Copy link
Contributor

mohierf commented May 7, 2019

@rednach: this morning I pushed a version of the ui-graphite module in a dedicated branch (see https://github.com/mohierf/mod-ui-graphite/tree/python3)

As of now, I am using :

  • alignak, branch module_on_module
  • mod-webui, branch python3
  • mod-ui-graphite, branch python3

And the modules are correctly loaded with Python 3. I did not yet tested that the ui graphite module is fully functional ... but I will od it soon

Note that both modumles are in the repositories on my own github

@maethor
Copy link
Contributor

maethor commented Nov 18, 2019

Hi,

I don't know how to review and merge this commit. Is it still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants