-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
about #715 #716
base: integ
Are you sure you want to change the base?
about #715 #716
Conversation
Thanks @rednach for this PR. I will integrate this in my most recent work and keep you informed. |
Thanks to you, @mohierf. In order to get shinken-ui injecting external commands into alignak, I am working in:
what do you think? better for me just to wait for your next commits? |
@rednach : have a look to the python3 branch in my own repo here: https://github.com/mohierf/mod-webui I already modified external commands behavior and it looks ok. Moreover this version is compatible with Python 3 ! |
@rednach I did some more testings and the module ui-graphite2 is not easily inclmuded by the current WebUI. My most recent push in the python3 branch is not yet fully functional but I will make more tests in the next few days! |
@mohierf Now, your python3 branch is working with alignak/develop (or alignak/module_on_module), but yet with the disable/enable trick to load ui-graphite2 (and another patch about "quote", I suppose because I use python 2). |
@rednach: I am still fixing this behaviour. I identified precisely what is the problem but do not have much time at the moment ... I will release an Alignak and WebUI version that ill make the job soon 😉 |
@rednach: this morning I pushed a version of the ui-graphite module in a dedicated branch (see https://github.com/mohierf/mod-ui-graphite/tree/python3) As of now, I am using :
And the modules are correctly loaded with Python 3. I did not yet tested that the ui graphite module is fully functional ... but I will od it soon Note that both modumles are in the repositories on my own github |
Hi, I don't know how to review and merge this commit. Is it still relevant? |
Defining ui-graphite with enabled=0 and this patch make graphs to appear.
Related with shinken-monitoring/mod-ui-graphite#24