サインアップ機能 #1
Merged
サインアップ機能 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
black(フォーマッタ)のチェックに失敗しました。CI実行のログを確認して修正し，再度コミット・プッシュしてください。 |
harune-pg
suggested changes
Nov 11, 2024
accounts/views.py
Outdated
|
|
||
| def form_valid(self, form): | ||
| response = super().form_valid(form) | ||
| print(self.object) |
tweets/views.py
Outdated
| @@ -1 +1,7 @@ | |||
| # from django.shortcuts import render | |||
accounts/tests.py
Outdated
| form = response.context["form"] | ||
|
|
||
| self.assertEqual(response.status_code, 200) | ||
| self.assertFalse(User.objects.filter(email=invalid_data["username"]).exists()) |
There was a problem hiding this comment.
63行目のfilterでemailとusernameを比較しているため、意図したチェックになっていないかもしれません。
他にも同様の箇所があるので、このファイル全体を見直してみてください！
具体的には、usernameフィールドがユニークなので、usernameでフィルターするといいです！
詳しい説明は、Wikiのサインアップ機能のページのSTEP5の04.の3. postのテストのdef test_success_post(self)の詳しい説明の3. self.assertTrue … の説明にあります。
harune-pg
reviewed
Nov 12, 2024
accounts/tests.py
Outdated
Comment on lines
95
to
97
| self.assertEqual(response.status_code, 200) | ||
| self.assertFalse(form.is_valid()) | ||
| self.assertIn("同じユーザー名が既に登録済みです。", form.errors["username"]) |
There was a problem hiding this comment.
test_failure_post_with_duplicated_userメソッドで、期待する効果「DBにレコードが追加されていないこと」のチェックが抜けているようです。
| self.assertFalse(form.is_valid()) | ||
| self.assertIn("このフィールドは必須です。", form.errors["password1"]) | ||
| self.assertIn("このフィールドは必須です。", form.errors["password2"]) |
There was a problem hiding this comment.
【提案（必須じゃない）】
password2に変えるなら、password1でも同じformエラーが出てるので、どっちも書いちゃってもいいかもです！
harune-pg
approved these changes
Nov 12, 2024
|
|
||
| self.assertEqual(response.status_code, 200) | ||
| self.assertFalse(form.is_valid()) | ||
| self.assertEqual(User.objects.filter(username=duplicated_data["username"]).count(), 1) |
There was a problem hiding this comment.
【提案（必須じゃない）】
やっていることは変わりませんが、valid_data["username"]を使った方が意味的に自然かと思います。こんな感じで修正してみてはいかがでしょうか？
Suggested change
| self.assertEqual(User.objects.filter(username=duplicated_data["username"]).count(), 1) | |
| self.assertEqual(User.objects.filter(username=valid_data["username"]).count(), 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
受講生の確認事項
１次レビュアーの確認事項