Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Release Manifest to pre-webhook nightly release #141

Conversation

ayushsatyam146
Copy link
Contributor

Changes

The Shipwright operator upstream currently deploys the v0.11.0 release of Shipwright Build. To get ready to deploy the webhook components, we should update the kodata/release.yaml with a more recent nightly release that does not include the v1beta1 conversion webhook

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qu1queee qu1queee requested review from adambkaplan and coreydaley and removed request for otaviof September 20, 2023 13:21
@jkhelil
Copy link
Contributor

jkhelil commented Sep 21, 2023

@ayushsatyam146
PR #140 is updating the release.yaml to latest build controller and webhook. There is no need to a new PR
I think we can close this

@adambkaplan
Copy link
Member

/close

Per @jkhelil's comment - #140 will supercede this PR.

@openshift-ci openshift-ci bot closed this Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@adambkaplan: Closed this PR.

In response to this:

/close

Per @jkhelil's comment - #140 will supercede this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants