Remove operatorhub from test catalog #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
openshift-ci
bot
added
the
kind/cleanup
|
/assign @coreydaley |
openshift-merge-robot
added
the
needs-rebase
`make install-olm` now deploys OLM with the upstream operatorhub.io catalog already included. We do not need to create our own operatorhub catalog for testing. This change also ensures that Shipwright will deploy with the latest upstream operator versions. Also added troubleshooting section for OLM-based development to add note regarding grpc/HTTP issues with OLM catalogs. Version was bumped to "0.13.0-rc0" so that our test catalog semantic version does not conflict with the current upstream version (0.12.0).
adambkaplan
force-pushed
the
olm-render-operatorhub
branch
from
902496d
to
c752aaa
Compare
openshift-merge-robot
removed
the
needs-rebase
apoorvajagtap
approved these changes
Nov 17, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove operatorhub from test catalog, and add troubleshooting section to OLM development doc.
make install-olmnow deploys OLM with the upstream operatorhub.io catalog already included. We do not need to create our own operatorhub catalog for testing. This change also ensures that Shipwright will deploy with the latest upstream operator versions.Version was bumped to "0.13.0-rc0" so that our test catalog semantic version does not conflict with the current upstream version (0.12.0).
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes