new version ready #12
ci.yml
on: push
Job rustfmt
4s
Job audit
11s
Matrix: Job tests
Job code coverage
0s
Annotations
12 errors and 23 warnings
Job audit
Critical vulnerabilities were found, marking check as failed
|
unneeded `return` statement:
doh/src/remote/helper.rs#L65
error: unneeded `return` statement
--> doh/src/remote/helper.rs:65:5
|
65 | return Ok(fragment_connection);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
65 - return Ok(fragment_connection);
65 + Ok(fragment_connection)
|
|
unneeded `return` statement:
doh/src/remote/helper.rs#L56
error: unneeded `return` statement
--> doh/src/remote/helper.rs:56:5
|
56 | return Ok(dial_result.stream);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
56 - return Ok(dial_result.stream);
56 + Ok(dial_result.stream)
|
|
unneeded `return` statement:
doh/src/remote/fragment.rs#L177
error: unneeded `return` statement
--> doh/src/remote/fragment.rs:177:5
|
177 | return rng.gen_range(min..=max) as usize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
177 - return rng.gen_range(min..=max) as usize;
177 + rng.gen_range(min..=max) as usize
|
|
unneeded `return` statement:
doh/src/handler.rs#L137
error: unneeded `return` statement
--> doh/src/handler.rs:137:13
|
137 | return get_response(context, cache_question, response, id, addr).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
137 - return get_response(context, cache_question, response, id, addr).await;
137 + get_response(context, cache_question, response, id, addr).await
|
|
redundant closure:
doh/src/context.rs#L32
error: redundant closure
--> doh/src/context.rs:32:22
|
32 | .map(|remote_session| Mutex::new(remote_session))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Mutex::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
field `addr` is never read:
doh/src/remote/mod.rs#L46
error: field `addr` is never read
--> doh/src/remote/mod.rs:46:5
|
44 | struct DialResult {
| ---------- field in this struct
45 | stream: TcpStream,
46 | addr: SocketAddr,
| ^^^^
|
= note: `DialResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
value assigned to `added` is never read:
doh/src/helper.rs#L42
error: value assigned to `added` is never read
--> doh/src/helper.rs:42:13
|
42 | let mut added = 0;
| ^^^^^
|
= help: maybe it is overwritten before being read?
= note: `-D unused-assignments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_assignments)]`
|
unused import: `futures::TryFutureExt`:
doh/src/run.rs#L6
error: unused import: `futures::TryFutureExt`
--> doh/src/run.rs:6:5
|
6 | use futures::TryFutureExt;
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
use of deprecated method `rustls::client::builder::<impl rustls::ConfigBuilder<rustls::ClientConfig, rustls::client::WantsTransparencyPolicyOrClientCert>>::with_single_cert`: Use `with_client_auth_cert` instead:
doh/src/config.rs#L26
error: use of deprecated method `rustls::client::builder::<impl rustls::ConfigBuilder<rustls::ClientConfig, rustls::client::WantsTransparencyPolicyOrClientCert>>::with_single_cert`: Use `with_client_auth_cert` instead
--> doh/src/config.rs:26:24
|
26 | config_builder.with_single_cert(cert_chain, key_der)?
| ^^^^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(deprecated)]`
|
Job clippy
Clippy had exited with the 101 exit code
|
Job clippy windows service
Clippy had exited with the 101 exit code
|
Job rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Job rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Job rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Job audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Job audit
1 vulnerabilities found!
|
Job audit
1 warnings found!
|
Job audit
Unknown warning kind unsound found, please, file a bug
|
Job clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Job clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Job clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy windows service
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Job clippy windows service
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Job clippy windows service
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy windows service
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy windows service
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Job clippy windows service
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|