Optimize the speed.

See https://en.wikibooks.org/wiki/Optimizing_Code_for_Speed . There may have been some refactorings too.
shlomif · Feb 1, 2025 · 1c4c624 · 1c4c624
1 parent e37deb3
commit 1c4c624
Showing 1 changed file with 23 additions and 16 deletions.
diff --git a/...litaire/Games-Solitaire-BlackHole-Solver/lib/Games/Solitaire/BlackHole/Solver/App/Base.pm b/...litaire/Games-Solitaire-BlackHole-Solver/lib/Games/Solitaire/BlackHole/Solver/App/Base.pm
@@ -25,23 +25,30 @@ my $const_attrs = [
 ];
 
 my $CHECK_SET_ONLY_ONCE = 0;
-foreach my $const_attr (@$const_attrs)
+if ( not $CHECK_SET_ONLY_ONCE )
 {
-    has $const_attr => (
-        is => 'rw',
-        (
-            $CHECK_SET_ONLY_ONCE
-            ? (
-                trigger => sub {
-                    my ( $self, $newval ) = @_;
-                    die "self=$self const_attr=$const_attr"
-                        if ( $self->{_CTR}->{$const_attr}++ );
-                    return;
-                }
-                )
-            : ()
-        )
-    );
+    has [@$const_attrs] => ( is => 'rw', );
+}
+else
+{
+    foreach my $const_attr (@$const_attrs)
+    {
+        has $const_attr => (
+            is => 'rw',
+            (
+                $CHECK_SET_ONLY_ONCE
+                ? (
+                    trigger => sub {
+                        my ( $self, $newval ) = @_;
+                        die "self=$self const_attr=$const_attr"
+                            if ( $self->{_CTR}->{$const_attr}++ );
+                        return;
+                    }
+                    )
+                : ()
+            )
+        );
+    }
 }
 
 # These attributes mutate during a solver's run.