Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use official health check module #32

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat: use official health check module #32

merged 1 commit into from
Jul 24, 2024
+4 −498

Conversation

david-zw-liu
Copy link
Contributor

@david-zw-liu david-zw-liu commented Jul 2, 2024 •
edited
Loading

某個版本開始 GRPC package 內建了 healthcheck proto，
會跟我們自己加的 healthcheck proto 有 name conflict，
改成統一用內建的 healthechk。

panic: proto: file "grpc/health/v1/health.proto" has a name conflict over grpc.health.v1.HealthCheckResponse
	previously from: "github.com/shoplineapp/go-app/plugins/grpc/healthcheck"
	currently from:  "google.golang.org/grpc/health/grpc_health_v1"
See https://protobuf.dev/reference/go/faq#namespace-conflict

--

自測:
image

@david-zw-liu david-zw-liu force-pushed the david/use-official-health-check branch from bd6bacd to ec4b774 Compare July 2, 2024 05:12
@neal-sl neal-sl merged commit b2508bd into master Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neal-sl neal-sl neal-sl approved these changes

@mgleon08 mgleon08 mgleon08 approved these changes

@rayway30419 rayway30419 rayway30419 approved these changes

@iscreen iscreen iscreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@david-zw-liu @iscreen @rayway30419 @mgleon08 @neal-sl