Merge branch 'master' into feature/PLAT-992-add-business-id-to-cronjo…

…b-chart

.github/workflows/test-cronjob-chart.yaml

@@ -0,0 +1,39 @@
+---
+name: Test cronjob chart
+
+on:
+  push:
+    paths:
+      - cronjob/**
+      - .github/workflows/**
+  pull_request:
+    paths:
+      - cronjob/**
+      - .github/workflows/**
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        helm-version:
+          - 3.1.0
+          - 3.2.3
+          - 3.2.4
+          - 3.3.0
+          - latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Helm ${{ matrix.helm-version }}
+        uses: azure/[email protected]
+        with:
+          version: ${{ matrix.helm-version }}
+
+      - name: Install Helm unittest plugin
+        run: |
+          helm plugin install https://github.com/helm-unittest/helm-unittest.git
+
+      - name: Run cronjob chart tests
+        run: |
+          helm unittest cronjob

README.md

@@ -44,4 +44,11 @@ vi ./example/subChart/requirements.yaml
 
 ```bash
 helm dependency update ./helm/preview
+```
+
+<!-- how to unit test -->
+### How to run unit tests
+
+```bash
+helm unittest <chart-name>
 ```

cronjob/.helmignore

@@ -2,3 +2,4 @@
 .github
 *.md
 *.tgz
+tests

cronjob/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 description: Helm chart with simple cronjob template
 name: cronjob
-version: 1.0.0
+version: 1.0.0xx
 appVersion: 1.0.0
 tillerVersion: ">=2.14.3"

cronjob/templates/_argo_cron_workflow.tpl

@@ -130,9 +130,11 @@
         -
           # If .Values.exitNotifications.slackApp is set, slackApp will be notify if the job is done 
           {{- if .Values.exitNotifications.slackApp }}
+          {{- if list nil true "true" | has .Values.exitNotifications.slackApp.sendOnSuccess }}
           - name: Notice-SlackApp-Succeeded
             template: notice-slack-app-succeeded 
           {{- end }}
+          {{- end }}
           # If .Values.exitNotifications.healthcheckIo is set, Healthcheck IO will be notify if the job is done
           {{- if .Values.exitNotifications.healthcheckIo }}
           - name: Notice-HealthcheckIo-Succeeded
@@ -144,9 +146,11 @@
         -
           # If .Values.exitNotifications.slackApp is set, slackApp will be notify if the job is failed
           {{- if .Values.exitNotifications.slackApp }}
+          {{- if list nil true "true" | has .Values.exitNotifications.slackApp.sendOnFailure }}
           - name: Notice-SlackApp-Failed
             template: notice-slack-app-failed 
           {{- end }}
+          {{- end }}
           # If .Values.exitNotifications.newRelic is set, New Relic will be notify if the job is failed
           {{- if .Values.exitNotifications.newRelic }}
           - name: Notice-NewRelic-Failed