Allow to skip creating serviceaccount #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesky6529
reviewed
Feb 15, 2024
| @@ -1,9 +1,15 @@ | |||
| {{- if .Values.serviceaccount }} | |||
| {{- if .Values.serviceaccount.skipCreation }} | |||
There was a problem hiding this comment.
We usually use create as a switch to determine whether resources need to be generated.
Comment on lines
+3
to
+5
| {{- /* | ||
| Skip create service account | ||
| */}} |
There was a problem hiding this comment.
I think users should be able to determine whether the resource will be created or not by themselves, so having this comment here would be too much.
| @@ -140,12 +140,14 @@ envFrom: {} | |||
| # - test-2-secret | |||
|
|
|||
| # Service account is used by pod. For more details on fields "serviceaccount" and "serviceAccount", please have a look on ./cronjob/templates/serviceaccount.yaml | |||
| # "serviceAccount" is deprecated, please use "serviceaccount" instead. | |||
| serviceaccount: {} | |||
There was a problem hiding this comment.
the following changes will make more common sense as below:
serviceaccount:
create: true
annotations:
eks.amazonaws.com/role-arn: <aws-role-arn>
name: <serviceaccount-name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to reuse created service account for deployment or cronjob, add
.Value.serviceaccount.skipCreationto control whether service account should be created.