fix placeonfloor function for models and primitives #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrancos-hub
force-pushed
the
next-39988/fix-boundingbox-calculation-for-placeonfloor
branch
from
a4db585 to
403a374
Compare
emreimamoglu
approved these changes
Dec 12, 2024
dfrancos-hub
force-pushed
the
next-39988/fix-boundingbox-calculation-for-placeonfloor
branch
2 times, most recently
from
a882296 to
119ca5a
Compare
ffrank913
requested changes
Dec 16, 2024
ffrank913
force-pushed
the
next-39988/fix-boundingbox-calculation-for-placeonfloor
branch
from
21e7ef2 to
90b0261
Compare
ffrank913
deleted the
next-39988/fix-boundingbox-calculation-for-placeonfloor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The current logic for placing scene objects in the floor is not working for all primitives / groups / models because it assumes a fixed, centered pivot point.
2. What does this change do, exactly?
This change aims to fix the place on floor the function so it behaves the same regardless of where the pivot point is located for a model or primitive
3. link to the relevant issue:
https://shopware.atlassian.net/browse/NEXT-39988