Bug: Invisible gizmo can still transform #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Because you could still transform a selected object via the gizmo even if it is hidden.
2. What does this change do, exactly?
It disables the tool's raycaster completely by disabling all bitmask layers.
We also added CodeCov to the project to take a look at the code coverage. This has no impact on the bug fix.
3. Describe each step to reproduce the issue or behaviour.
Select an object.
Make sure the gizmo is attached and visible.
Hide the gizmo.
Click at the position one of the axis was before and drag.
The object should NOT move.
4. Please link to the relevant issues (if any).
5. Checklist