Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Invisible gizmo can still transform #58

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

ffrank913
Copy link
Contributor

@ffrank913 ffrank913 commented Jan 3, 2025

1. Why is this change necessary?

Because you could still transform a selected object via the gizmo even if it is hidden.

2. What does this change do, exactly?

It disables the tool's raycaster completely by disabling all bitmask layers.

We also added CodeCov to the project to take a look at the code coverage. This has no impact on the bug fix.

3. Describe each step to reproduce the issue or behaviour.

Select an object.
Make sure the gizmo is attached and visible.
Hide the gizmo.
Click at the position one of the axis was before and drag.
The object should NOT move.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@ffrank913 ffrank913 force-pushed the bug/invisible-gizmo-transform branch from e2e0199 to 332609f Compare January 3, 2025 08:05
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ffrank913 ffrank913 force-pushed the bug/invisible-gizmo-transform branch from 332609f to 5644a8f Compare January 3, 2025 08:15
@ffrank913 ffrank913 force-pushed the bug/invisible-gizmo-transform branch from 5644a8f to 734d6fc Compare January 3, 2025 08:17
@ffrank913 ffrank913 marked this pull request as ready for review January 3, 2025 08:18
@ffrank913 ffrank913 self-assigned this Jan 3, 2025
@ffrank913 ffrank913 merged commit 73fb495 into trunk Jan 6, 2025
7 checks passed
@ffrank913 ffrank913 deleted the bug/invisible-gizmo-transform branch January 6, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants