Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zip command to adjust ExtensionConfig and dump .shopware-extension.yml #473

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

shyim
Copy link
Member

@shyim shyim commented Feb 10, 2025

Update the ExtensionConfig to set validation.ignore to meta.setup when --overwrite-app-backend-secret is passed to the zip command and dump the .shopware-extension.yml file again before zipping.

  • Modify cmd/extension/extension_zip.go to adjust the ExtensionConfig and set validation.ignore to meta.setup when --overwrite-app-backend-secret is passed.
  • Add logic to dump the .shopware-extension.yml file again before zipping when --overwrite-app-backend-secret is passed.
  • Add a Dump method to the Config struct in extension/config.go to handle the dumping of the configuration to the .shopware-extension.yml file.

For more details, open the Copilot Workspace session.

shyim and others added 2 commits February 10, 2025 16:36
…n.yml

Update the `ExtensionConfig` to set `validation.ignore` to `meta.setup` when `--overwrite-app-backend-secret` is passed to the zip command and dump the `.shopware-extension.yml` file again before zipping.

* Modify `cmd/extension/extension_zip.go` to adjust the `ExtensionConfig` and set `validation.ignore` to `meta.setup` when `--overwrite-app-backend-secret` is passed.
* Add logic to dump the `.shopware-extension.yml` file again before zipping when `--overwrite-app-backend-secret` is passed.
* Add a `Dump` method to the `Config` struct in `extension/config.go` to handle the dumping of the configuration to the `.shopware-extension.yml` file.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/shopware/shopware-cli?shareId=XXXX-XXXX-XXXX-XXXX).
@shyim shyim merged commit 11d213e into main Feb 12, 2025
7 checks passed
@shyim shyim deleted the shyim/fix-zip-command branch February 12, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant