Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move the rest of FAQ.md to docs.shorebird.dev #17

Merged
merged 4 commits into from
Apr 27, 2023
Merged

docs: Move the rest of FAQ.md to docs.shorebird.dev #17

merged 4 commits into from
Apr 27, 2023

Conversation

eseidel
Copy link
Contributor

@eseidel eseidel commented Apr 27, 2023

I did some small updates to the FAQs as I moved them. I did not make any attempt to sort these by frequency.

@eseidel eseidel enabled auto-merge (squash) April 27, 2023 02:20
Comment on lines +42 to +46
I haven't measured recently, but I expect the code push library to add less than
one megabyte to Flutter apps. `flutter build apk --release` vs.
`shorebird build apk --release` should give you a rough idea. We know of ways
we can make this smaller when that becomes a priority. If size is a blocker
for you, please let us know!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #19 so we can at least give a ballpark idea of the size difference, which should help readers determine whether/how much of a blocker this might be.

a user opens a web app it downloads the latest version from the server if
needed.

If you have a use case for code push with Fluter web, we'd love to know!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have a use case for code push with Fluter web, we'd love to know!
If you have a use case for code push with Fluter web, [we'd love to know](https://github.com/shorebirdtech/shorebird/issues/new?assignees=&labels=feature&template=feature_request.md&title=feat%3A+)!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to be formatted

@@ -28,7 +156,7 @@ For more information about why we had to fork Flutter see

## When do updates happen?

Shorebird udpater is currently hard-coded to run on app startup. It runs on
Shorebird updater is currently hard-coded to run on app startup. It runs on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Shorebird updater is currently hard-coded to run on app startup. It runs on
The Shorebird updater is currently hard-coded to run on app startup. It runs on

Copy link
Contributor

@bryanoltman bryanoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, but lgtm!

@eseidel eseidel merged commit 7760e90 into main Apr 27, 2023
@eseidel eseidel deleted the faq branch April 27, 2023 02:55
bryanoltman added a commit that referenced this pull request Apr 27, 2023
bryanoltman added a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants