midi.py: Fix to remove repeated note from sustained_notes #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem with prematurely terminating a note on pedal-up (release of piano sustain). Previously, the sequence [pedal down, play & release notes (they sustain), play one of the sounding notes again, hold it down but release the pedal] would execute a note-off for the note that was being held down, because its note-off from the release of the first chord was still pending.
With this fix, note-on ensures the note in question is not in the list of deferred note-offs, so it is not prematurely terminated.
Thanks to matt-har-vey for identifying the problem and providing the fix!