Use Promises for ListView onRefresh #232
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with an issue that in
ListView
RefreshControl spins forever...Someone recommend to use ListView loading prop to Dismiss refreshControl, but it seems in ListView Statuses are strings like
Status.IDLE
,Status.REFRESHING
and so on, but the loading prop is a boolean value and it cause issues.Currently refresh Control automatically set ListView Component
status: Status.REFRESHING
and then callthis.props.onRefresh
that I was passed from MyComponent.In MyComponent I have an state like
this.state.loading : false
and when I want to setloading
prop, I should set it tothis.setState({loading: true})
on MyComponentonRefresh
prop, so as soon as ListViewcomponentWillReceiveProps
triggered, refreshControl will disappear ( in Less than one second ), because my status state is not equals to ListView component status state. So there is no possibility to keep spins without hacks.so Its nice to use Promise to handle this issue.