Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable pollution in cost calculations #113

Closed
wants to merge 1 commit into from

Conversation

shpaass
Copy link
Owner

@shpaass shpaass commented May 7, 2024

Most Pyanodons' users play without pollution. If they do play with pollution, then they likely use other approaches to figure out which recipe to use.

Closes #111

@shpaass shpaass changed the title feat: disable pollution in cost calculations disable pollution in cost calculations May 7, 2024
@shpaass shpaass force-pushed the disable-pollution-in-cost-calculations branch from fd4a308 to 664ae43 Compare May 8, 2024 06:52
@veger
Copy link
Collaborator

veger commented May 8, 2024

I see you decided to keep the calculations around and just set the factor to 0? If we never plan to enable it again, it might be better to fully remove to reduce maintenance?

@shpaass
Copy link
Owner Author

shpaass commented May 8, 2024

We might enable it again once PyAliens gets released -- the one about biters.

Most Pyanodons' users play without pollution. If they do play with pollution, then they likely use other apps to figure out which recipe to use.

Closes #111
@shpaass shpaass force-pushed the disable-pollution-in-cost-calculations branch from 664ae43 to 77bcdc3 Compare May 8, 2024 08:01
@Dorus
Copy link
Collaborator

Dorus commented May 9, 2024

I would prefer #117 with a setting. ^_^

@shpaass shpaass marked this pull request as draft May 9, 2024 11:39
@shpaass shpaass closed this May 9, 2024
@shpaass
Copy link
Owner Author

shpaass commented May 9, 2024

Superceded by #117

@shpaass shpaass deleted the disable-pollution-in-cost-calculations branch June 21, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Change CostPerPollution to zero
3 participants