New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 35806d61, which broke the selection of fluid ingredient variants. #136

Merged

shpaass merged 1 commit into shpaass:master from DaleStan:fix-fluid-ingredient-selection

May 23, 2024

Collaborator

DaleStan commented May 22, 2024

In 35806d6, I changed recipe.links.ingredientGoods[i] to ingredient.goods, and that broke this dropdown in the ingredients column.

This changes it back and fixes the dropdown.


          Fix 35806d6, which broke the selection of fluid ingredient variants.

59eb220

The various steam temperatures are most notable here.

Owner

shpaass commented May 23, 2024

To clarify the bug, the steps to reproduce are as follows:

Select any item that accepts a fluid ingredient with variants. For instance, Agar.
Select a different variant.
Observe that the fluid variant doesn't change.

The behavior of the fixed version is that the fluid variant changes.

shpaass approved these changes

View reviewed changes

shpaass merged commit d2a36bf into shpaass:master

1 check passed

DaleStan deleted the fix-fluid-ingredient-selection branch

May 25, 2024 21:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet