Lightning collectors #397
Merged
Lightning collectors #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
reviewed
Jan 28, 2025
DaleStan
force-pushed
the
lightning-collectors
branch
2 times, most recently
from
79daf56 to
08caf1e
Compare
shpaass
approved these changes
Jan 30, 2025
|
One more question: should we keep the markdown with the lightning formulas next to the code, or move to the docs folder? I do not feel strong/happy about having non-code files next to the code, but it wouldn't be a show stopper for me. So for me either way is fine |
Now that you mention it, you're right. |
DaleStan
force-pushed
the
lightning-collectors
branch
from
08caf1e to
9e89ab4
Compare
veger
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds lightning collectors as electricity sources (when paired with accumulators), covering tasks 1 and 3 of #319. Discord discussion of #390 was leaning toward a square grid. There didn't seem to be strong opinions on how effective the accumulators should be, so I picked 10%. Both of these could be configured, but I chose not to do that for now.
I also chose to hardcode Fulgoran storm properties (#319, task 2), but left todos behind for where they would need to be changed.