Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHRINKDESC-125] Add exportAsString-esque facility for Node SPI #88

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rbattenfeld
Copy link

Hi Andrew

This feature is requested by Jesper. Can you review it?

I simply added the exportAsString functionality defined for descriptors into the Node class since the existing toString() is not usable IMO.

Thanks
Ralf

@ALRubinger
Copy link
Member

As I understand it, this would be a new feature to the SPI only, not to any of the API or *-prototype modules.

Also I think it'd be appropriate to accept some "Formatters" so that the String could have a custom formatting scheme (or one of our own canned ones). We have a very similar example in place in ShrinkWrap Archive.toString(Formatter). So while I completely appreciate this PR, perhaps we could limit the scope and tackle the requirements as above? WDYT?

@rbattenfeld
Copy link
Author

I am happy to make inline as it is with the shrinkwrap Archive toString() behaviour. Make sense to me.

@ALRubinger
Copy link
Member

Cool. Recommend a new branch based off current upstream/master, then
having another go if you'd like ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants