Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use TelemetryResourceDetector for telemetry sdk values when creating default resource #1974

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

the-wondersmith
Copy link
Contributor

PR removes the need to manually keep pinned version of opentelemetry-sdk in sync with static string value in runtime/src/telemetry.rs

Credit: lalitb's suggestion here

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR improves telemetry setup in the Shuttle runtime by automating SDK version tracking and simplifying resource creation.

  • Uses TelemetryResourceDetector to automatically provide SDK telemetry values instead of manual version strings in runtime/src/telemetry.rs
  • Aligns opentelemetry_sdk version to 0.27.0 in runtime/Cargo.toml to match other OpenTelemetry dependencies
  • Simplifies resource creation by merging auto-detected SDK information with custom attributes

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@the-wondersmith the-wondersmith merged commit 90cb292 into main Jan 31, 2025
21 checks passed
@the-wondersmith the-wondersmith deleted the chore/runtime/dynamic-telemetry-sdk-version branch January 31, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants