Idempotent mediator invitation url #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clément Humbert <[email protected]>
|
If the invite is the same as last time, don't we want to skip creation of a new connection? |
burdettadam
reviewed
Sep 9, 2021
|
Thanks for the review guys. This is the kind of feedback I was looking for since I'm still not fully acquainted with aca-py. I will submit an update next week. |
To ease Aca-py's deployment in scenarios where command line arguments cannot be changed easily, make `--mediatior-invitation` and `--mediator-connections-invite` available to the `provision` command. `provision` stores the mediator invite to be used by `start` command. If the invitation changed, `start` updates the stored invite and uses the new one. Signed-off-by: Clément Humbert <[email protected]>
chumbert
force-pushed
the
idempotent-mediator-invitation-url
branch
from
2a14100 to
eeb1fbf
Compare
Whenever the conductor needs to setup a new mediation connection (eg: the invitation url provided by the command line arguments has changed), clear the old default mediator settings prior to setting up the new connection and default mediator. Signed-off-by: Clément Humbert <[email protected]>
burdettadam
approved these changes
Sep 13, 2021
|
Thanks for the review, I'll open a PR on the original repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediary PR to make sure everything fits before proposing this on aca-py main repo.
Connection to the mediator is now established using the url stored at provision-time. If the invitation is changed, the new one is stored and used.
A new connection is still established at each start.