Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Didcomm message field "typ" should be optional #96

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Didcomm message field "typ" should be optional #96

merged 2 commits into from
Mar 30, 2023

Conversation

dkulic
Copy link
Contributor

@dkulic dkulic commented Mar 30, 2023

@dkulic dkulic requested a review from yvgny March 30, 2023 13:41
@dkulic
Copy link
Contributor Author

dkulic commented Mar 30, 2023

typ is no more required to be present when parsing the message (if it is present its value is checked).
When creating message, we include typ for maximum compatibility.

@dkulic dkulic mentioned this pull request Mar 30, 2023
Closed
@dkulic dkulic merged commit 406932b into main Mar 30, 2023
@dkulic dkulic deleted the feat/typ_should_be_optional branch March 30, 2023 14:01
@FabioPinheiro FabioPinheiro mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvgny yvgny yvgny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkulic @yvgny