Merge pull request #107 from keithsue/sufay/optimize-params-validation

Optimize params validation
sideprotocol · Jul 9, 2024 · 390650a · 390650a
2 parents 6bfa524 + 490546b
commit 390650a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/x/btcbridge/types/params.go b/x/btcbridge/types/params.go
@@ -2,6 +2,7 @@ package types
 
 import (
 	"bytes"
+	"encoding/hex"
 
 	secp256k1 "github.com/btcsuite/btcd/btcec/v2"
 	"github.com/btcsuite/btcd/btcutil"
@@ -61,7 +62,12 @@ func (p Params) Validate() error {
 		}
 
 		if len(vault.PubKey) != 0 {
-			_, err := secp256k1.ParsePubKey([]byte(vault.PubKey))
+			pkBytes, err := hex.DecodeString(vault.PubKey)
+			if err != nil {
+				return err
+			}
+
+			_, err = secp256k1.ParsePubKey(pkBytes)
 			if err != nil {
 				return err
 			}