Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add manifest properties on Windows binaries #666

Open
brantgurga opened this issue Oct 3, 2024 · 1 comment
Open

[feature] add manifest properties on Windows binaries #666

brantgurga opened this issue Oct 3, 2024 · 1 comment

Comments

@brantgurga
Copy link
Contributor

Problem Description

Similar to siderolabs/talos#9429 the Windows binary for omnictl is currently not filled with properties. This is mostly informational though I do know Windows Installer looks at the file versions if it were used to distribute binaries. The file version field seems like the most useful and informative field to fill in. Those properties are currently blank.
image

Solution

Something like go-winres (https://github.com/tc-hib/go-winres) looks like it can be used with the Go ecosystem to fill in that manifest information.

Alternative Solutions

Investigation into tooling to support it also had led me to using windres from something like mingw to compile the manifest into a resource, but that's bringing in tooling outside the Go ecosystem so seems like a less favorable approach.

Notes

No response

@brantgurga
Copy link
Contributor Author

I got this proof of concept working as illustrated. The executable has an icon which I left as the default one go-winres produced and some basic executable properties are filled in though they likely need reviewed and tweaked. Build pipeline integration likely needs tweaked too. I'll make a branch/pull request with what I did.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant