Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Windows Resources implementation #667

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brantgurga
Copy link
Contributor

POC draft for #666

I'm sure there's tweaks from what I did on this.

@brantgurga
Copy link
Contributor Author

I got a branch of the kres repository and figured out the basic place to output the steps. Need to figure out if I need the --mount-type=cache arguments to RUN which were in my manually edited Dockerfile. Also need to use a tagged version of go-winres most likely instead of @latest and right now it puts the lines for all the targets which I think is okay since it creates objects that only get compiled in for Windows, but it's probably better to just output the lines when windows is the target

@brantgurga
Copy link
Contributor Author

The key file in kres seems to be internal\projects\golang\build.go.
Run make image-kres to build a local image. Copy the output local image and use in running kres on the omni folder.
MSYS_NO_PATHCONV=1 docker run --rm --net=host --user 197609:197609 -v /C/Users/brant/repositories/omni:/src -w /src -e GITHUB_TOKEN ghcr.io/brant/kres:34e72ac-dirty

it's smart enough to skip whatever GITHUB interaction without a GITHUB_TOKEN set. The MSYS_NO_PATHCONV=1 is needed since I'm currently doing this from MSYS but docker is not MSYS so it doesn't need to do path conversion to run and actually fails if run in the msys shell without that set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant