Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added warning about NVMe bus path bug #9597

Conversation

solidDoWant
Copy link
Contributor

Pull Request

What? (description)

As discussed here, this adds a warning to the docs about a bug with bus path matching for NVMe drives.

Note that website/content/v1.9/reference/configuration/v1alpha1/config.md dropped some comments for some reason... not sure why.

Why? (reasoning)

Maintainers have elected to not fix the bug. This helps other users be aware of the issue, the impact of it, and how to mitigate it.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@solidDoWant solidDoWant requested a review from smira October 30, 2024 18:23
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@smira smira force-pushed the solidDoWant/document-nvme-bus-path-issue-1 branch from e8b2d07 to 064ccce Compare October 31, 2024 10:31
Document NVMe bus path.

Signed-off-by: solidDoWant <[email protected]>
Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira force-pushed the solidDoWant/document-nvme-bus-path-issue-1 branch from 064ccce to d8b6521 Compare October 31, 2024 10:32
@smira smira added this to the v1.9 milestone Oct 31, 2024
@smira
Copy link
Member

smira commented Oct 31, 2024

/m

@talos-bot talos-bot merged commit d8b6521 into siderolabs:main Oct 31, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants