Convert package interface to Typescript #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was challenging to split the rest into several PRs so here is the full conversion of package interface to typescript.
Some comments to the files added and important changes...
.prettierrc
esling.config.mjs
warn
package.json
packages/iframe-service/src/iframe-service.ts
messageChild
did not match the typeMessagePayload
messageChild
, and alsomessageParent
in packages/interface/src/service.ts.The delay input will now be set to 0 instead of blank when using backspace to delete the numbers.
I refactored some of the runtime code like
generatePrefUpdate
in settings-tab.tsx, since now passing a constructed event value instead of an empty string inclearClicked
onChange
in theClearableInput
component in common.tsx.I also changed all event.target to event.currentTarget since some HTML element types don't have an event.target.
Tested with both browser and Thunderbird and seems to work as expected.