Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various tweaks of build machinery and OpenSSL version support and test fixes #42

Merged
merged 40 commits into from
Feb 15, 2024
Merged

Various tweaks of build machinery and OpenSSL version support and test fixes #42

merged 40 commits into from
Feb 15, 2024

Conversation

DDvO
Copy link
Member

@DDvO DDvO commented Jan 15, 2024 •
edited
Loading

For details please see the commit messages.

@DDvO DDvO added the enhancement New feature or request label Jan 15, 2024
@DDvO
Makefile_src: fix handling of rpath for MacOS with System Integrity P…
6355976 
…rotection (SIP)
@DDvO
Makefile_v1,README.md: move clean_config to 'clean' target and add hi…
46e6931 
…nt on openssl_backport.h not found
@DDvO
cmpClient.c: fix error handling calling UTIL_safe_string_copy() and U…
cf521d9 
…TIL_bintohex()
@DDvO
cmpClient.c: refactor save_certs(), making order of parameters more l…
2efe9b8 
…ogical
@DDvO
cmpClient.c: improve error message on -extracerts_dir_format or -cace…
30e9cd0 
…rts_dir_format argument not accepted
@DDvO
cmpClient.c: support -extracerts_dir and -crl_cache_dir without separ…
e79c07f 
…ator '/' at dir path end
@DDvO
CMakeLists.txt: make sure libcmp (if used) is linked before libcrypto
d79904a 
This prevents crash of OSSL_CMP_CTX_get1_extraCertsIn()
@DDvO
CMakeLists.txt: update OPENSSL_VERSION assignment to include 3.3, def…
83bc104 
…ault now 3.0
@DDvO
CMakeLists.txt,README.md: switch default CMake build mode to Release;…
59c40ca 
… rearrange some text
@DDvO
debian/source/options: add tar-ignore entries such as .dylib and debi…
8f044e2 
…an/shlibs
@DDvO DDvO changed the title Various tweaks of build machinery for supporting OpenSSL 3-3-dev and MacOS Various tweaks of build machinery and OpenSSL version support and test fixes Feb 9, 2024
@DDvO DDvO force-pushed the build_Release+MacOS branch 2 times, most recently from fdbb603 to c7b2af2 Compare February 12, 2024 20:34
@DDvO
README.md: tweak text on build tool dependencies
abb6b71
@DDvO
CMakeLists.txt,Makefile_src: replace outdated add_definitions() by ad…
6d00ea2 
…d_compile_options() etc.
@DDvO
cmpossl: add changes by branch build_Release+MacOS
d613bdb
@DDvO
cmpossl,cmpClient.c,genericCMPClient.{c,h}: support OpenSSL 3.3 pre-r…
e808ca9 
…elease
@DDvO
README.md,Makefile_v1: update list of supported OpenSSL versions and …
56ef2dd 
…related default version: 3.0
@DDvO
CMakeLists.txt,Makefile_src: consistently disable compiler flag for C…
16f338a 
…90 standard
@DDvO
CMakeLists.txt: fix include_directories(...) for libcmp vs. OpenSSL s…
ee7d1f2 
…ystem includes
@DDvO
Makefile_src: tweak order of -lcmp and -lsecutils when linking
70b9872
@DDvO
Makefile_src,REAMD.md: add STATIC_LIBCMP option to allow statically l…
fcac8e5 
…inking libcmp with libgencmp
@DDvO
genericCMPClient.c: suppress misleading error message of get_genm_ita…
677620e 
…v() on rejection
@DDvO
cmpClient.c: in do_genm() add dynamic OpenSSL version to warning that…
514100f 
… infotype is not supported
@DDvO
cmpClient.c: tweak OID data definitions in complete_genm_asn1_objects()
5fc608b
@DDvO
test/: fix text cases mostly regarding server_dn vs. ca_dn and expect…
c041f45 
…ed sender
@DDvO
Makefile_tests: fix startup of CmpCaMock for tests_LwCmp
38e2c8d
@DDvO
Makefile_tests: fix server path for CmpRa in conformance tests
3e43287
DDvO and others added 13 commits February 12, 2024 22:05
@DDvO
Makefile_v1: exclude pkcs10 test case from demo_Insta (not supported …
f8ee3f3 
…by Insta CA)
@DDvO
Makefile_{v1,tests}: adapt grace check and comments w.r.t test cases …
aeffc5a 
…not supported by OpenSSL versions
@DDvO
Makefile_v1: make EJBCA docker TLS host name detection more flexible …
160668b 
…and add error on failure
@DDvO
Makefile_v1: avoid stopping EJBCA docker container because restart wi…
eeeb7db 
…ll take long time
@DDvO
cmpossl/ossl_cmp_calc_protection(): handle potential overflow of sig_len
8d82c9d
@DDvO
README.md: tweak text on using demo_CloudCA
19d1fbe
@DDvO
Makefile_v1: add demo_all including demo_EJBCA and demo_CloudCA
cd8ac22
@DDvO
build.yml: make sure that test_all uses 'USE_LIBCMP=1'
3a19c68
@DDvO
config/{demo.cnf,EJBCA.env},Makefile_v1: fix reference to CMP client …
75628ba 
…key by manufacturer
@DDvO
cmpossl/OSSL_CMP_snprint_PKIStatusInfo(): silence warning by adding t…
2221fa7 
…ype cast
@DDvO
cmpossl/OSSL_CMP_validate_cert_path(): fix type of 'err' variable
f901a1c
@DDvO
Revert "docs: add credential format options for cmpClient"
3e51532 
This reverts commit cb0cbfe.

The described options are not really available with cmpClient.
@DDvO
cmpossl/http_client.c: fix conversions from long to int
87b715c
@DDvO DDvO force-pushed the build_Release+MacOS branch 3 times, most recently from a2c2fb8 to ee5af67 Compare February 13, 2024 06:49
@DDvO
Copy link
Member Author

DDvO commented Feb 13, 2024 •
edited
Loading

@rajeev-0 could you please check why test_Mock (as part of test_all) still fails
for some test cases using the most recent genm/genp related features.
I tried to make sure using USE_LIBCMP=1 that all features are supported, but for some reason this does not really work.

@rajeev-0
Copy link
Collaborator

@rajeev-0 could you please check why test_Mock (as part of test_all) still fails for some test cases using the most recent genm/genp related features. I tried to make sure using USE_LIBCMP=1 that all features are supported, but for some reason this does not really work.

Two test cases genm caCerts & genm certReqTemplate are failing, because build CI is using OpenSSL 3.0 and these genm are not supported in mock server.

@DDvO
Copy link
Member Author

DDvO commented Feb 15, 2024 •
edited
Loading

Oops, Rufus, requesting a review from you was by accident.

@DDvO DDvO merged commit cdce391 into master Feb 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeev-0 rajeev-0 rajeev-0 approved these changes

@RufusJWB RufusJWB Awaiting requested review from RufusJWB

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DDvO @rajeev-0