-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debug): improved debug messages #55
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements suggested.
Here are some requests for tweaking them.
All implemented. Thank you for the proposals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you for the contribution!
@RufusJWB could you please squash you commits, |
Moved this to #61 |
11c9731
to
99a7d3b
Compare
done |
Please check the output of the CI test_all run:
Somehow the new diagnostic output confuses a Makefile used for the tests. |
|
Hmm, the test_all CI run still fails the same way. |
BTW, would be nice not to have merge commits. |
The CI still fails, supposedly because there is still one output line containing the string |
Argh, just recalled that this PR was still in trouble, Fixed by directing all the new diagnostic output to |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also CI confirms that the issue is fixed, finally.
Motivation
Simplify debugging
Proposed Changes
Improving log messages
Test Plan
n/a