Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many build improvements, fixing clang and OpenSSL version and CMake find_package() issues #61

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Many build improvements, fixing clang and OpenSSL version and CMake find_package() issues #61

wants to merge 10 commits into from

Conversation

rajeev-0
Copy link
Collaborator

@rajeev-0 rajeev-0 commented Oct 15, 2024 •
edited by DDvO
Loading

Among others, fix CMake find_package() occasionally incorrectly reporting error in finding OpenSSL.

  • README.md: require at least OpenSSL version 3.0
  • files.c: remove incompatible #define OSSL_DEPRECATEDIN_3_1
  • Makefile_v1: add -Werror only if NDEBUG is defined
  • CMakeLists.txt: add workaround for using non-installed OpenSSL builds with default libdir
  • Makefile_v1,README.md: major update with improved diagnostics
  • src/CMakeLists.txt: remove -Werror. It is enabled only for development and CI, using Makefile_v1 without NDEBUG
  • CMakeLists.txt,REAME.md: improve use and diagnostics of OpenSSL package detection
  • Makefile_v1: clean target: avoid errors trying to remove files not (anymore) existing
  • src/CMakeLists.txt,README.md: add support for clang version 19.1.1 (adding -Wno-gnu-folding-constant)

@DDvO DDvO changed the title remove REQUIRED from find_package for OpenSSL as it occasionally fails. support new clang versions; remove -Werror on debug builds; remove REQUIRED from find_package() for OpenSSL Oct 18, 2024
@DDvO
Copy link
Member

DDvO commented Oct 19, 2024

This meanwhile provides more thorough fixes for various build issues also with Makefile_v1,
extending also the diagnostics on finding the OpenSSL include directory and libraries.

@DDvO DDvO force-pushed the fix_cmake_openssl branch 2 times, most recently from 8b38d7a to 992b92e Compare October 21, 2024 19:08
@DDvO
Copy link
Member

DDvO commented Oct 21, 2024

@benjamin-schilling and @rajeev-0 finally, really ready for review.

@DDvO DDvO changed the title support new clang versions; remove -Werror on debug builds; remove REQUIRED from find_package() for OpenSSL Many build improvements, fixing clang and OpenSSL version and CMake find_package() issues Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

@benjamin-schilling benjamin-schilling Awaiting requested review from benjamin-schilling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajeev-0 @DDvO