Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one workspace for all packages #181

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

ChaoticTempest
Copy link
Contributor

@ChaoticTempest ChaoticTempest commented Feb 8, 2025

this unifies all packages under one workspace:

  • remove once_cell::Lazy since std::sync::LazyLock is pretty much the same and would use one less dep.
  • removes the caching step from docker builds because we don't rebuild that often anymore. We just build an image once and if it works, we deploy it now vs back then when we need images for tests.

Copy link
Contributor

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. We still have the Docker option in tests. Not sure if we even need it.

@ChaoticTempest ChaoticTempest merged commit a2582ad into develop Feb 11, 2025
2 of 3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/feat/one-workspace branch February 11, 2025 01:10
@volovyks
Copy link
Contributor

@ChaoticTempest looks like deploy node CI task is failing, probably because of the wrong paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants