fix: push failed signature request into sign queue for non-proposers #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
reviewed
Feb 14, 2025
added 2 commits
February 14, 2025 15:41
ChaoticTempest
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered that eth requests fail when it did not succeed on 1st generator, and need to retry.
Poking the logs, I find that the non-proposer nodes were warning
waiting for indexer. This means that the request has been removed from sign_queue, and not added back.This should affect near requests as well, but likely near block time is fast thus less delay on indexer side, thus most requests finish in first attempt.