Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pomerium): HA with Postresql backend #35

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alfonsofortunato
Copy link

No description provided.

Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the changes introduced in #34 please rebase with latest changes on main.

Also, CI is failing, you need to add the license headers to the new YAML files postgres/kustomization.yaml and postgres/postgresql.yml

@alfonsofortunato alfonsofortunato force-pushed the feat/pomerium-postgres-ha branch 3 times, most recently from 4f22e00 to be0c2c0 Compare November 14, 2024 10:25
@alfonsofortunato
Copy link
Author

I don't see the changes introduced in #34 please rebase with latest changes on main.

Also, CI is failing, you need to add the license headers to the new YAML files postgres/kustomization.yaml and postgres/postgresql.yml

Merged the main and added the license

@@ -4,3 +4,5 @@ COOKIE_SECRET=super-secret-cookie
IDP_CLIENT_SECRET=super-secret-idp
# SHARED_SECRET is obtained with `head -c32 /dev/urandom | base64` see https://www.pomerium.io/reference/#shared-secret
SHARED_SECRET=super-secret-shared

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This env var is missing:

Suggested change
DATABROKER_STORAGE_TYPE=postgres

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in "config.example.env"

helm.sh/chart: postgresql-16.0.3
type: Opaque
data:
postgres-password: "b29wOU9kOHV3ZWk2U29vQnVhaGFlZmF4"
Copy link
Member

@ralgozino ralgozino Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we ask for this password to the user or is it safe to leave it hard coded?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've generated with the helm template (more details in the MAINTANANCE.MD). The safer way is have the password hardcoded. In any case by following the maintanance guide the user can customize the password as he wish

@ralgozino
Copy link
Member

IMO this PR should not be included as-is, Pomerium in HA is considerable slower, to the point that Hubble for example stops working and Grafana is painfully slow to use.

I don't know if is some misconfiguration or could be something on my test environment.

@ralgozino ralgozino changed the title Feat/pomerium postgres ha feat(pomerium): HA with Postresql backend Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants