-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pomerium): HA with Postresql backend #35
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the changes introduced in #34 please rebase with latest changes on main.
Also, CI is failing, you need to add the license headers to the new YAML files postgres/kustomization.yaml
and postgres/postgresql.yml
4f22e00
to
be0c2c0
Compare
Merged the main and added the license |
be0c2c0
to
38c1a66
Compare
@@ -4,3 +4,5 @@ COOKIE_SECRET=super-secret-cookie | |||
IDP_CLIENT_SECRET=super-secret-idp | |||
# SHARED_SECRET is obtained with `head -c32 /dev/urandom | base64` see https://www.pomerium.io/reference/#shared-secret | |||
SHARED_SECRET=super-secret-shared | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This env var is missing:
DATABROKER_STORAGE_TYPE=postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in "config.example.env"
helm.sh/chart: postgresql-16.0.3 | ||
type: Opaque | ||
data: | ||
postgres-password: "b29wOU9kOHV3ZWk2U29vQnVhaGFlZmF4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we ask for this password to the user or is it safe to leave it hard coded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've generated with the helm template (more details in the MAINTANANCE.MD). The safer way is have the password hardcoded. In any case by following the maintanance guide the user can customize the password as he wish
IMO this PR should not be included as-is, Pomerium in HA is considerable slower, to the point that Hubble for example stops working and Grafana is painfully slow to use. I don't know if is some misconfiguration or could be something on my test environment. |
No description provided.