Fixed single albums sometimes not being recognized as albums #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigma67
reviewed
Dec 17, 2023
| if not result_type and video_type: | ||
| result_type = 'song' if video_type == 'MUSIC_VIDEO_TYPE_ATV' else 'video' | ||
| if not result_type: | ||
| if search_result["category"] == "Albums": |
There was a problem hiding this comment.
Hi @polvallverdu , thanks for your contribution. However, this will not work without localization. Note that "category" is not used anywhere else for code flow for this reason. Only result_type is localization independent (after delocalization in l.59)
There was a problem hiding this comment.
Ahh, I'll try to investigate it later today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #483
@theyak was right. The issue was related to not recognizing albums being albums