-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_album: track_number returns none when track unavailable + test #516
Conversation
Co-authored-by: sigma67 <[email protected]>
Side note on the new pipeline, these code coverage checks that keep failing. Am I supposed to be doing something differently? My local tests are passing. Also I've yet to get mypy to run correctly, it always throws errors about missing type stubs related to requests, despite having installed them via pip and mypy directly. Any recommendations?
|
becca0f
to
ad73362
Compare
Don't worry about the test/coverage check, it cannot work yet for external contributors. Right now it only works for people with access to the secrets of this repo, because that's how GitHub does Pull Requests. To get it to work you'd have to set the following variables in your fork (just copy paste the text of the equivalent files you use locally): Normally you'd only have to run |
Alright cool. I'll give that a whirl.
Yea I've run |
Seems to be a common issue with the precommit mypy action, I remember having some trouble with it as well. Try this: https://stackoverflow.com/a/73603491/5726546 Feel free to update the file in a PR if it works for you |
Simple fix for #515 and adds test case for albums with unavailable tracks.
Issue could alternatively be solved by extending nav's none_if_absent to coerce nullish return values. thoughts?