WIP removed the apparently-unnecessary anyOf blocks #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should include the indent changes here too. I usually do a round-trip in python but I think people also use |
Teque5
requested changes
Feb 5, 2025
sigmf-schema.json
Outdated
| @@ -76,7 +91,7 @@ | |||
| "default": 0, | |||
| "minimum": 0, | |||
| "!comment": "The maximum value for this property is equal to 2^63 - 1, making it easy to fit into a signed 64-bit integer.", | |||
| "maximum": 9223372036854775807, | |||
| "maximum": 9223372036854776000, | |||
There was a problem hiding this comment.
I don't think you meant to change these. This number is 2**63 + 192. Was previously max signed integer.
|
:-O blames |
|
I suppose if we were smart we would use an integer small enough such that |
Teque5
approved these changes
Feb 6, 2025
|
I now notice that the jq-ification rewrote 1e12 -> 1000000000000 which I dislike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that (for clarity on the substantive edits) this does not include appropriate indent-level changes.
Closes #337