End to end tests in Golang #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
continuous_ingest
branch
from
54cb349
to
fe13a81
Compare
jinja2
reviewed
Oct 7, 2023
e2e_tests/e2e_test.go
Outdated
Comment on lines
48
to
55
| // export KUBECONFIG=/tmp/kube-config-splunk-otel-collector-chart-e2e-testing | ||
| // export K8S_VERSION=v1.28.0 | ||
| // kind create cluster --kubeconfig=/tmp/kube-config-splunk-otel-collector-chart-e2e-testing --config=.github/workflows/configs/e2e-kind-config-$K8S_VERSION.yaml | ||
| // cd e2e_tests/testdata/nodejs | ||
| // docker build -t nodejs_test:latest . | ||
| // kind load docker-image nodejs_test:latest --name kind | ||
| // make cert-manager | ||
| // kubectl get csr -o=jsonpath='{range.items[?(@.spec.signerName=="kubernetes.io/kubelet-serving")]}{.metadata.name}{" "}{end}' | xargs kubectl certificate approve |
There was a problem hiding this comment.
This can be automated w/ existing and updated helpers: https://github.com/signalfx/splunk-otel-collector/tree/main/tests/testutils/kubeutils.
There was a problem hiding this comment.
We will need this PR or equivalent functionality to use helpers, right now they hardcode v1.26, which is something we modulate on to test different versions of Kubernetes.
atoulme
force-pushed
the
continuous_ingest
branch
from
e4115bc
to
72faedc
Compare
|
Let me pause work on this PR while we get #949 squared away. I'll address your feedback in changes there first. |
atoulme
force-pushed
the
continuous_ingest
branch
from
72faedc
to
910b9fb
Compare
atoulme
force-pushed
the
continuous_ingest
branch
from
4fc7fbc
to
e792ab0
Compare
|
OK, this is in a better place now. I can refactor to use helpers now, let me see what I can do. |
dmitryax
reviewed
Oct 12, 2023
atoulme
force-pushed
the
continuous_ingest
branch
from
259b290
to
9b1f638
Compare
|
@atoulme looks like the test are failing |
dmitryax
approved these changes
Oct 13, 2023
jvoravong
approved these changes
Oct 13, 2023
|
A few follow ups on this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an effort to create a set of tests that can listen to the different data inputs from the chart, and refer to them for testing. The cluster can continuously report data in, and we can use this data to assert based on the deployment.
This test runs against kind with a variety of kubernetes versions.