Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add default certificate caching behaviour #107

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

crienzo
Copy link
Member

@crienzo crienzo commented Apr 10, 2021

No description provided.

@crienzo crienzo requested a review from a team April 10, 2021 12:31
@crienzo crienzo changed the title Add user data to context Add default certificate caching behaviour Apr 10, 2021
@crienzo
Copy link
Member Author

crienzo commented Apr 10, 2021

Reopen of #106

Copy link
Member

@emcgee emcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crienzo Does this still need merging?

@@ -10,7 +10,7 @@ You can find a comprehensive list of specs relevant to Shaken at the bottom of t
## libstirshaken

This library provides building blocks for implementing STIR-Shaken authentication and verification services, (STI-SP/AS, STI-SP/VS),
as well as elements of STI-CA and STI-PA.
as well as elements of STI-CA and STI-PA. It supports HHTPs and SSL. Certificates can be cached and served from cache (user may implement custom callback or use default caching mechanism).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS

@crienzo
Copy link
Member Author

crienzo commented Oct 23, 2021

I had to reopen in my name after piotr kept repeatedly closing the PR. Not sure if we want to take this or not because it's a massive change and we did fine at the last opensipit with our round of fixes to the lib. We'll re-evaluate after the next opensipit next month.

@crienzo crienzo changed the title Add default certificate caching behaviour WIP Add default certificate caching behaviour Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants