decouple eth2 from store and lighthouse_network
#6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: Pawan Dhananjay <[email protected]>
dknopik
force-pushed
the
decouple-eth2
branch
from
7f33d35 to
903bae0
Compare
jxs
reviewed
Jan 10, 2025
|
@jxs, applied the changes we discussed, feel free to take a look again |
|
This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏 |
# Conflicts: # Cargo.lock # common/eth2/Cargo.toml
|
Dropping this from v7.0.0 as I imagine it's most useful in unstable, and we can do that later |
michaelsproul
added
ready-for-review
|
Doing some triage. Would be good to merge this soon. Maybe @macladson could take a quick look as second reviewer? 🙏 |
|
this cuts the number of deps in half, thank you @dknopik 😭 |
macladson
reviewed
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Remove dependencies on
storeandlighthouse_networkfrometh2. This was achieved as follows:enrandmultiaddrdirectly instead of usinglighthouse_network's reexports.lighthouse_networkresponsible for converting between API and internal types.serde_json::Valueinstead - this is not ideal, but should be fine for now, as this affects two internal non-spec endpoints which are meant for debugging, unstable, and subject to change without notice anyway. Inspired by Remove lighthouse_network dependency from eth2 crate #6679. The alternative is to move all relevant types toeth2ortypesinstead - what do you think?Additional Info
In my opinion, this only partially fixes the issue above, as we probably still should split out lighthouse-specific features.